feat(user.js): consolidate CP userscripts and deprecate legacy CP scripts by netravnen · Pull Request #283 · peeringdb/admincom

netravnen · 2026-02-17T22:09:23Z

Summary

This PR consolidates all peeringdb-cp-* functionality into a single modular userscript with strict route isolation and hard no-op guards outside intended contexts.

It also migrates legacy CP scripts to deprecation stubs (console notice only) with synchronized bugfix version bumps in both .user.js and .meta.js, and updates user.js/README.md with migration guidance.

What changed

Added consolidated CP script pair:
- user.js/peeringdb-cp-consolidated-tools.user.js
- user.js/peeringdb-cp-consolidated-tools.meta.js
Consolidated architecture:
- central route context resolver + dispatcher
- per-module match(ctx), preconditions(), run()
- shared utilities for safe querying, toolbar action insertion, org lookup, and idempotent action registration
Preserved network action behavior:
- immediate Save+Continue for network update/reset flows
- robust name assignment fallback handling
Converted legacy CP scripts to deprecation stubs (behavior removed, console notice added):
- peeringdb-cp-add-facility-address-search-to-google-maps.*
- peeringdb-cp-admin-console-set-link-target-blank-for-entity-website.*
- peeringdb-cp-control-panel-hightlight-dummy-organization-child-object.*
- peeringdb-cp-frontpage-link-on-admin-console.*
- peeringdb-cp-reset-all-network-information.*
- peeringdb-cp-search-user-e-mail-addresses-from-username.*
- peeringdb-cp-set-network-name-equal-to-organisation-name.*
Updated docs:
- user.js/README.md migration and deprecation notes

Metadata + scope decisions

Host scope restricted to www.peeringdb.com
Consolidated script uses @match
Consolidated scope:
- https://www.peeringdb.com/cp/peeringdb_server/*/*/change/*
Legacy .meta.js and .user.js headers kept version-synchronized

Route-by-route verification checklist

Validation notes

Static checks in workspace reported no syntax/problems.
Manual browser verification pending (checklist above).

Follow-up

After checklist completion, this PR is ready for review/merge.

…ipts

…tion

netravnen · 2026-02-17T22:14:27Z

Toolbar regression fix pushed in d524742.

What changed:

addToolbarAction now inserts isolated sibling
- directly into the built-in #grp-content-title > ul list.
- This avoids interfering with the native CP toolbar/history layout implementation.
- Consolidated script version bumped to 1.0.1.20260217 in both .user.js and .meta.js.
Please re-verify on CP pages that toolbar/history layout is intact and actions render correctly without duplicates.

netravnen · 2026-02-17T22:16:39Z

Follow-up toolbar clickability fix pushed in f4f1f77.

Issue:

Only Google Maps and History were clickable because overlapping custom toolbar
Fix:
- Set pointer-events: none on each injected wrapper
  - Set pointer-events: auto on each injected action link.
  - Bumped consolidated script version to 1.0.2.20260217 in both .user.js and .meta.js.
  Please re-test facility/network pages and confirm all custom action links are clickable.

…reset

netravnen · 2026-02-17T22:59:18Z

Added RDAP ASN fallback for reset flow in commit ce75b70.

What it does:

Introduces an isolated RDAP client module (rdapAutnumClient) outside feature-module logic.
Uses IANA ASN bootstrap registry (RFC 9224) to find authoritative RDAP base URL.
Queries /autnum/{asn} and resolves organization name from RDAP entities/jCard data with registrant-first scoring.
In reset action: if both resolved network name and original network name are empty, performs RDAP lookup using integer ASN (#id_asn) and uses that organization name (plus deleted suffix when applicable) before save.

Version bump:

Consolidated script/meta updated to 1.0.3.20260217.

netravnen · 2026-02-17T23:01:35Z

Adjusted reset fallback order in commit 2aa4794.

What it does:

Removes dependency on original network name in the reset flow.
Uses resolved network name from org API as the primary source.
If resolved network name is empty, falls back directly to isolated RDAP ASN lookup (rdapAutnumClient).
Keeps deleted-network suffix handling unchanged when a name is resolved.

Version bump:

Consolidated script/meta updated to 1.0.4.20260217.

netravnen · 2026-02-17T23:05:17Z

Hardened first-run reset save behavior in commit a0d923f.

What it does:

Keeps reset name resolution order: org API first, RDAP ASN second.
Adds a final deterministic guard before save: if name is still empty, set it to AS<asn> (or AS<networkId> as fallback) with deleted suffix handling.
Prevents required-field validation from blocking clickSaveAndContinue on first run.

Version bump:

Consolidated script/meta updated to 1.0.5.20260218.

…submit

netravnen · 2026-02-17T23:17:00Z

Update: pushed an additional hardening fix for the alternating Reset Information behavior.

What changed

Version bump: 1.0.7.20260218
Avoid clearing #id_name in the bulk reset pass
Added direct #id_name setter (value + defaultValue + input/change events)
Seed deterministic fallback name immediately after reset (AS<asn> / AS<networkId> + deleted suffix)
Keep org/RDAP resolution, with a final pre-submit direct guard on #id_name

Commit

95bd461 — fix(user.js): harden reset name assignment against alternating empty submit

Early results look good; continuing route-by-route verification.

netravnen · 2026-02-23T20:33:58Z

Update: pushed inline deletion-guard changes for Network CP actions.

What changed

Version bump: 1.0.9.20260223
Added status-aware inline handling so deletion marking only applies when the row status is already deleted
Applied to these inline sets:
- poc_set (network contact)
- netfac_set (network facilities)
- netixlan_set (network ix lans)
Wired into both actions on /cp/peeringdb_server/network/*/change/:
- Reset Information
- Update Name

Behavior guarantee

If inline row status is deleted → mark for deletion (right-column cross)
If inline row status is not deleted → do not mark for deletion

Commit

3621e7d — fix(user.js): only auto-delete network inlines with deleted status

netravnen · 2026-02-23T20:57:42Z

Update: pushed a tiny UX-only naming standardization pass (Org terminology).

What changed

Version bump: 1.0.15.20260223
Standardized button labels to compact Org naming for consistency:
- Organization (front-end) → Org (front-end)
- Organization → Org
- Copy organisation URL → Copy Org URL
- Copy success text updated to Copied Org URL

Commit

398845c — chore(user.js): standardize toolbar labels to Org naming

Note

Remote branch feat/cp-unified-userscript-modular-runtime-isolation had previously been deleted and is now restored/pushed again.

feat(user.js): consolidate CP userscripts and deprecate legacy CP scr…

8ac1ade

…ipts

netravnen self-assigned this Feb 17, 2026

netravnen added copilot llm-built enhancement PDB labels Feb 17, 2026

fix(user.js): preserve CP toolbar layout in consolidated action injec…

d524742

…tion

fix(user.js): make all CP toolbar action links clickable

f4f1f77

netravnen added 2 commits February 17, 2026 23:36

docs(user.js): document version format major.minor.bugfix.YYYYMMDD

0cf1f65

feat(user.js): add isolated RDAP ASN fallback for empty network name …

ce75b70

…reset

fix(user.js): use resolved name then RDAP fallback only in reset flow

2aa4794

fix(user.js): guarantee non-empty reset name before save

a0d923f

fix(user.js): harden reset name assignment against alternating empty …

95bd461

…submit

fix(user.js): only auto-delete network inlines with deleted status

3621e7d

netravnen merged commit 3621e7d into master Feb 23, 2026

netravnen deleted the feat/cp-unified-userscript-modular-runtime-isolation branch February 23, 2026 20:37

netravnen added userscript Tampermonkey/Greasemonkey userscript changes bug labels Feb 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(user.js): consolidate CP userscripts and deprecate legacy CP scripts#283

feat(user.js): consolidate CP userscripts and deprecate legacy CP scripts#283
netravnen merged 9 commits intomasterfrom
feat/cp-unified-userscript-modular-runtime-isolation

netravnen commented Feb 17, 2026 •

edited

Loading

Uh oh!

netravnen commented Feb 17, 2026

Uh oh!

netravnen commented Feb 17, 2026

Uh oh!

netravnen commented Feb 17, 2026

Uh oh!

netravnen commented Feb 17, 2026

Uh oh!

netravnen commented Feb 17, 2026

Uh oh!

netravnen commented Feb 17, 2026

Uh oh!

netravnen commented Feb 23, 2026

Uh oh!

netravnen commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

netravnen commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What changed

Metadata + scope decisions

Route-by-route verification checklist

Validation notes

Follow-up

Uh oh!

netravnen commented Feb 17, 2026

Uh oh!

netravnen commented Feb 17, 2026

Uh oh!

netravnen commented Feb 17, 2026

Uh oh!

netravnen commented Feb 17, 2026

Uh oh!

netravnen commented Feb 17, 2026

Uh oh!

netravnen commented Feb 17, 2026

What changed

Commit

Uh oh!

netravnen commented Feb 23, 2026

What changed

Behavior guarantee

Commit

Uh oh!

netravnen commented Feb 23, 2026

What changed

Commit

Note

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

netravnen commented Feb 17, 2026 •

edited

Loading